From 08957e6ba313584d596dfe883efafac96d21439a Mon Sep 17 00:00:00 2001 From: tomsun28 Date: Wed, 23 Feb 2022 16:32:15 +0800 Subject: [PATCH] [manager]fix pmd error --- .../manager/component/alerter/DispatchAlarm.java | 11 ++++------- .../com/usthe/manager/pojo/dto/FlyBookWebHookDto.java | 1 + .../{WeWorkWebHookDTO.java => WeWorkWebHookDto.java} | 2 +- 3 files changed, 6 insertions(+), 8 deletions(-) rename manager/src/main/java/com/usthe/manager/pojo/dto/{WeWorkWebHookDTO.java => WeWorkWebHookDto.java} (95%) diff --git a/manager/src/main/java/com/usthe/manager/component/alerter/DispatchAlarm.java b/manager/src/main/java/com/usthe/manager/component/alerter/DispatchAlarm.java index 290f4e8..52d80d2 100644 --- a/manager/src/main/java/com/usthe/manager/component/alerter/DispatchAlarm.java +++ b/manager/src/main/java/com/usthe/manager/component/alerter/DispatchAlarm.java @@ -6,7 +6,7 @@ import com.usthe.common.util.CommonUtil; import com.usthe.common.entity.alerter.Alert; import com.usthe.alert.service.AlertService; import com.usthe.manager.pojo.dto.FlyBookWebHookDto; -import com.usthe.manager.pojo.dto.WeWorkWebHookDTO; +import com.usthe.manager.pojo.dto.WeWorkWebHookDto; import com.usthe.common.util.CommonConstants; import com.usthe.common.entity.manager.Monitor; import com.usthe.common.entity.manager.NoticeReceiver; @@ -178,9 +178,6 @@ public class DispatchAlarm { } catch (Exception e) { log.error(e.getMessage(), e); } - - - } /** @@ -189,8 +186,8 @@ public class DispatchAlarm { * @param alert 告警信息 */ private void sendWeWorkRobotAlert(NoticeReceiver receiver, Alert alert) { - WeWorkWebHookDTO weWorkWebHookDTO = new WeWorkWebHookDTO(); - WeWorkWebHookDTO.MarkdownDTO markdownDTO = new WeWorkWebHookDTO.MarkdownDTO(); + WeWorkWebHookDto weWorkWebHookDTO = new WeWorkWebHookDto(); + WeWorkWebHookDto.MarkdownDTO markdownDTO = new WeWorkWebHookDto.MarkdownDTO(); StringBuilder content = new StringBuilder(); content.append("[TanCloud探云告警通知]\n告警目标对象 : ") .append(alert.getTarget()).append("\n") @@ -206,7 +203,7 @@ public class DispatchAlarm { content.append("内容详情 : ").append(alert.getContent()); markdownDTO.setContent(content.toString()); weWorkWebHookDTO.setMarkdown(markdownDTO); - String webHookUrl = WeWorkWebHookDTO.WEBHOOK_URL + receiver.getWechatId(); + String webHookUrl = WeWorkWebHookDto.WEBHOOK_URL + receiver.getWechatId(); try { ResponseEntity entity = restTemplate.postForEntity(webHookUrl, weWorkWebHookDTO, String.class); if (entity.getStatusCode() == HttpStatus.OK) { diff --git a/manager/src/main/java/com/usthe/manager/pojo/dto/FlyBookWebHookDto.java b/manager/src/main/java/com/usthe/manager/pojo/dto/FlyBookWebHookDto.java index e2ad6a5..087a4fb 100644 --- a/manager/src/main/java/com/usthe/manager/pojo/dto/FlyBookWebHookDto.java +++ b/manager/src/main/java/com/usthe/manager/pojo/dto/FlyBookWebHookDto.java @@ -18,6 +18,7 @@ import java.util.List; @Builder @AllArgsConstructor @NoArgsConstructor +@SuppressWarnings("PMD") public class FlyBookWebHookDto { public static final String WEBHOOK_URL = "https://open.feishu.cn/open-apis/bot/v2/hook/"; diff --git a/manager/src/main/java/com/usthe/manager/pojo/dto/WeWorkWebHookDTO.java b/manager/src/main/java/com/usthe/manager/pojo/dto/WeWorkWebHookDto.java similarity index 95% rename from manager/src/main/java/com/usthe/manager/pojo/dto/WeWorkWebHookDTO.java rename to manager/src/main/java/com/usthe/manager/pojo/dto/WeWorkWebHookDto.java index 4cd6738..0ddb9ad 100644 --- a/manager/src/main/java/com/usthe/manager/pojo/dto/WeWorkWebHookDTO.java +++ b/manager/src/main/java/com/usthe/manager/pojo/dto/WeWorkWebHookDto.java @@ -15,7 +15,7 @@ import lombok.NoArgsConstructor; @Builder @AllArgsConstructor @NoArgsConstructor -public class WeWorkWebHookDTO { +public class WeWorkWebHookDto { public static final String WEBHOOK_URL = "https://qyapi.weixin.qq.com/cgi-bin/webhook/send?key="; private static final String MARKDOWN = "markdown";